Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JF v3.2 i2c support #252

Merged
merged 10 commits into from Jun 20, 2020
Merged

JF v3.2 i2c support #252

merged 10 commits into from Jun 20, 2020

Conversation

@trentgill
Copy link
Collaborator

@trentgill trentgill commented Nov 17, 2019

Adds crow support for new i2c features in Just Friends v3.2 (forthcoming).

One new setter:

  • voice_pitch(channel,pitch) is like play_voice but doesn't trigger the envelope for legato playing.

Getters:

  • run_mode: returns the just-type run status (not the hardware jack). 0=off, 1=on
  • mode: returns the synthesis/geode mode setting: 0=normal mode, 1=synthesis/geode
  • speed: returns the setting of the speed switch: 0=shape, 1=sound
  • tsc: returns the setting of the MODE switch: 0=transient, 1=sustain, 2=cycle

Questions:

  • should boolean states be 0/1 (not 1/2?)
  • should the 'tsc' switch be 1/2/3 (probably it's lua, and it's not a boolean?)
  • naming of 'mode' (changing to synthesis/geode mode) is a weird clash with the JF front panel 'MODE' for the 'tsc' switch. Would like to change but would break existing scripts (probably not worth it).
@trentgill trentgill changed the base branch from master to main Jun 18, 2020
@tehn
tehn approved these changes Jun 19, 2020
Copy link
Member

@tehn tehn left a comment

excited for this!

@trentgill trentgill removed the do not merge label Jun 20, 2020
@trentgill
Copy link
Collaborator Author

@trentgill trentgill commented Jun 20, 2020

This is ready for final testing. Requires new JF & Crow firmwares. JF3.2 to be co-released with Crow 2.0

@trentgill trentgill merged commit f537ccd into main Jun 20, 2020
1 check passed
1 check passed
build
Details
@trentgill trentgill deleted the jf-i2c-v3.2 branch Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants