Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoftCut: engine.rate(i,f) unable to handle negative values, under certain conditions #193

Closed
dndrks opened this issue Sep 4, 2018 · 3 comments
Assignees

Comments

@dndrks
Copy link
Contributor

@dndrks dndrks commented Sep 4, 2018

Outside of MLR, direct application of engine.rate(i,f) causes severe playback glitching if f values are less than 0. Application of positive f values behaves as desired.

Steps to replicate:

  1. load @tehn 's halfsecond.lua through Maiden
  2. toggle HOLD on norns to freeze the buffer at 1x
  3. execute engine.rate(1,-1) -> playback glitches
  4. execute engine.rate(1,1)-> eventually, playback re-stabilizes

I'm unsure if there's a condition unique to halfsecond.lua that causes this (vs MLR), but I have also replicated in other WIP SoftCut scripts.

@dndrks
Copy link
Contributor Author

@dndrks dndrks commented Sep 4, 2018

this also might just be my complete unawareness of certain conditions that need to be met for the reverse playback to function, but since positive f values produce desired results I feel like it's something worth logging.

@catfact
Copy link
Collaborator

@catfact catfact commented Sep 4, 2018

i'll have a look and take the opportunity to try (again) and fix write-head resampling

@catfact catfact self-assigned this Sep 4, 2018
@catfact
Copy link
Collaborator

@catfact catfact commented Oct 6, 2018

i'm pretty sure this artifact is from writing while reversing. in MLR the write head is never also the play head. in halfsecond the play head is also always writing, and just varying pre/rec gain levels.

i'll fix this, sorry i've been so slow, busy couple of months.

@catfact catfact closed this Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants