Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ack: ADSR envelope #288

Closed
audionerd opened this issue Jan 26, 2019 · 5 comments
Closed

ack: ADSR envelope #288

audionerd opened this issue Jan 26, 2019 · 5 comments

Comments

@audionerd
Copy link
Contributor

@audionerd audionerd commented Jan 26, 2019

i'd like to sustain notes with ack.

maybe with a new argument to the SynthDef:

playbackMode = 0 // 0 for one-shot, 1 for ADSR

so that existing scripts would not have to change.

when set to 1 for ADSR, it would enable more arguments for the envelope:

volumeEnvDecay = 0.3
volumeEnvSustainLevel = 0.5
volumeEnvPeakLevel = 1

and maybe even

volumeEnvCurve = -4
volumeEnvBias = 0

when gate is 0, the envelope begins to close.

i have a prototype of this working for the Engine_Ack SynthDefs, and could submit a PR.

is there any interest in this feature for ack? or should it be part of a new engine?

@antonhornquist
Copy link
Collaborator

@antonhornquist antonhornquist commented Jan 27, 2019

FWIW I have a separate engine for this, but its not pushed yet (a poly Ack thing).

@audionerd
Copy link
Contributor Author

@audionerd audionerd commented Jan 27, 2019

Cool. Looking forward to your new engine.

@audionerd audionerd closed this Jan 27, 2019
@justmat
Copy link
Contributor

@justmat justmat commented Mar 25, 2019

@audionerd any chance you still have this working somewhere? There has been some interest expressed over on lines :)

@audionerd
Copy link
Contributor Author

@audionerd audionerd commented Mar 26, 2019

@notjustmat I only prototyped a change to the SynthDefs in an .scd, I never actually updated Engine_Ack.

@justmat
Copy link
Contributor

@justmat justmat commented Mar 26, 2019

Ah, sorry for the misunderstanding! I guess it is about time I get acquainted with the SC side of Norns :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants