New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added KarplusRings.sc engine and complimentary melody generator #114

Merged
merged 3 commits into from Jun 15, 2018

Conversation

Projects
None yet
4 participants
@jonpauldavies
Contributor

jonpauldavies commented Jun 11, 2018

Hi!

Here is an engine KarplusRings.sc based on the SC Pluck uGen with a few filters added. I've also added a discoverable melody generator in scripts/burn/kayan.lua.

Any problems, please let me know.

Jon / @burn on lines

@tehn

this looks fantastic. can you remove the .DS_Store files? we should add .DS_Store to .gitignore

-- create all of the note and probability data on init
function create_sequence_data()
for i=1, 64 do
sequence.note_data[i] = scale_data[math.random (1, 24)];

This comment has been minimized.

@dndrks

dndrks Jun 12, 2018

Contributor

optimization suggestion (apologies if unwelcome, I'm just so in love with this script!): sequence.note_data[i] = scale_data[math.random (1, #scale_data)]; would allow for dynamic sequencing based on custom scales that might be shorter or longer than 24 entries.

@jonpauldavies

This comment has been minimized.

Contributor

jonpauldavies commented Jun 12, 2018

Here you go!

.DS_Store files nuked and better handling of custom scales. The defined scale gets copied over 4 octaves so that the range switching works. Any probs please let me know.

cheers

Jon

@jonpauldavies

This comment has been minimized.

Contributor

jonpauldavies commented Jun 12, 2018

This one please. Fixed bug when using pentatonic or shorter scales.

@tehn

tehn approved these changes Jun 12, 2018

fantastic!

@ngwese

This comment has been minimized.

Member

ngwese commented Jun 15, 2018

...i'm going to go ahead an merge this as it's been approved.

@ngwese ngwese merged commit bd967a6 into monome:master Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment