Added KarplusRings.sc engine and complimentary melody generator #114
Conversation
…ts/burn/kayan.lua
|
this looks fantastic. can you remove the .DS_Store files? we should add .DS_Store to .gitignore |
scripts/burn/kayan.lua
Outdated
| -- create all of the note and probability data on init | ||
| function create_sequence_data() | ||
| for i=1, 64 do | ||
| sequence.note_data[i] = scale_data[math.random (1, 24)]; |
dndrks
Jun 12, 2018
•
Contributor
optimization suggestion (apologies if unwelcome, I'm just so in love with this script!): sequence.note_data[i] = scale_data[math.random (1, #scale_data)]; would allow for dynamic sequencing based on custom scales that might be shorter or longer than 24 entries.
optimization suggestion (apologies if unwelcome, I'm just so in love with this script!): sequence.note_data[i] = scale_data[math.random (1, #scale_data)]; would allow for dynamic sequencing based on custom scales that might be shorter or longer than 24 entries.
|
Here you go! .DS_Store files nuked and better handling of custom scales. The defined scale gets copied over 4 octaves so that the range switching works. Any probs please let me know. cheers Jon |
|
This one please. Fixed bug when using pentatonic or shorter scales. |
|
fantastic! |
|
...i'm going to go ahead an merge this as it's been approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi!
Here is an engine KarplusRings.sc based on the SC Pluck uGen with a few filters added. I've also added a discoverable melody generator in scripts/burn/kayan.lua.
Any problems, please let me know.
Jon / @burn on lines