Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foulgrid - grid based instrument based on foulplay #157

Closed
wants to merge 6 commits into from

Conversation

@junklight
Copy link
Contributor

@junklight junklight commented Jul 23, 2018

I've added grid support to the foulplay script

I have pisound/rpi/push2 based setup so not been tested on official hardware

@pq
Copy link
Collaborator

@pq pq commented Jul 23, 2018

cool stuff. if this just adds grid support, it would probably be better to add it foulplay itself... unless you considered that?

/cc @notjustmat

@justmat
Copy link
Contributor

@justmat justmat commented Jul 23, 2018

I was just looking at this. I agree with @pq, in that it should probably just be added to foulplay.

@junklight
Copy link
Contributor Author

@junklight junklight commented Jul 23, 2018

the reason I made it separate is that there is discussion on lines about using Norns without the grid and the play fair variants get mention there.

It should be ok with no grid plugged in but I have no way of testing that. But if that works then happy to merge it into foulplay.....

@junklight
Copy link
Contributor Author

@junklight junklight commented Jul 23, 2018

ok - do I make a PR to your repo? or do you want to do the merge? (my git skills are pretty basic)

@justmat
Copy link
Contributor

@justmat justmat commented Jul 23, 2018

I am preparing a PR from my repo now, so why not submit it there. That way I can test it on hardware and make sure that it still works sans grid before it gets into monome/dust.

@junklight
Copy link
Contributor Author

@junklight junklight commented Jul 23, 2018

ah ok - your script is a bit ahead of where I forked - got a few meetings now - might not get to this until wednesday......

@justmat
Copy link
Contributor

@justmat justmat commented Jul 23, 2018

No worries!

junklight added 2 commits Jul 23, 2018
Merge remote-tracking branch 'notjustmat/master'
@junklight
Copy link
Contributor Author

@junklight junklight commented Jul 23, 2018

@junklight junklight closed this Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants