Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds track rotation and auto-save/ load to foulplay #163

Merged
merged 9 commits into from Jul 31, 2018
Merged

Adds track rotation and auto-save/ load to foulplay #163

merged 9 commits into from Jul 31, 2018

Conversation

@justmat
Copy link
Contributor

@justmat justmat commented Jul 28, 2018

Had a bit of a git hiccup, but everything is good now.

updates foulplay.lua with rotation per track, and save/ recall. also updates foulplay.md with the new details.

justmat added 8 commits Jul 28, 2018
@pq
pq approved these changes Jul 31, 2018
Copy link
Collaborator

@pq pq left a comment

awesome!

@@ -65,6 +61,15 @@ copy to return to normal use.

# extended explanations

### saving/ loading your work

foulplay will automatically save its _current state*_ whenever (a) you switch scripts, or (b) when norns _sleeps_.

This comment has been minimized.

@pq

pq Jul 31, 2018
Collaborator

this is a footnote? aside: i wonder if there's a better way... i can't recall how these markdown files are getting processed but it'd be nice to figure out something a bit more elegant (and capture it in wiki/FAQ).

This comment has been minimized.

@justmat

justmat Jul 31, 2018
Author Contributor

I'm sure there is a better way. I wanted to include the saving feature in the docs, but as there is no user interaction in saving... I was unsure how to go about it. Should I just omit this part?

This comment has been minimized.

@pq

pq Jul 31, 2018
Collaborator

na. docs are good. just a meta-note about how it'd be nice to have a better way to do footnotes.

@@ -86,8 +80,10 @@ local BeatClock = require 'beatclock'

local clk = BeatClock.new()

local ALT = 0

This comment has been minimized.

@pq

pq Jul 31, 2018
Collaborator

no biggie but curious why the screaming caps?

This comment has been minimized.

@justmat

justmat Jul 31, 2018
Author Contributor

Haha, no reason at all. I will turn down the volume now :)

This comment has been minimized.

@pq

pq Jul 31, 2018
Collaborator

ha! sounds good. maybe save 'em for when you really want to go to 11. 🤘

@justmat
Copy link
Contributor Author

@justmat justmat commented Jul 31, 2018

alt is much more user friendly now :D

@pq
pq approved these changes Jul 31, 2018
Copy link
Collaborator

@pq pq left a comment

👍

@pq pq merged commit d4328c9 into monome:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants