[Fm7 ][BUG] flip the mod params to do what they say #230
Conversation
First draft at an annotated TestSine supercollider class to run on Norns. Lua parts next...
| [hz1_to_hz3, hz2_to_hz3, hz3_to_hz3, hz4_to_hz3, hz5_to_hz3, hz6_to_hz3], | ||
| [hz1_to_hz4, hz2_to_hz4, hz3_to_hz4, hz4_to_hz4, hz5_to_hz4, hz6_to_hz4], | ||
| [hz1_to_hz5, hz2_to_hz5, hz3_to_hz5, hz4_to_hz5, hz5_to_hz5, hz6_to_hz5], | ||
| [hz1_to_hz6, hz2_to_hz6, hz3_to_hz6, hz4_to_hz6, hz5_to_hz6, hz6_to_hz6]]; |
catfact
Oct 12, 2018
Collaborator
i admit that it pains me a bit to have hz used as a label for parameters whose unit is not, in fact, cycles per second but rather a unitless frequency ratio (hz1, hz2...) or modulation amount.
i admit that it pains me a bit to have hz used as a label for parameters whose unit is not, in fact, cycles per second but rather a unitless frequency ratio (hz1, hz2...) or modulation amount.
lazzarello
Oct 12, 2018
Author
Contributor
me too. I can clean that up.
me too. I can clean that up.
|
be sure to fetch/pull before you push as to not have redundancies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The modulation parameters for FM7 were backwards.
There are also some stuff I snuck in from my fork's master branch after merging upstream/master into my fork. It's all documentation changes.
There are a couple script changes, which I don't really understand where they came from. I think a code review would be a good idea.