Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc apps on Ansible don't ever clear the LEDs #35

Closed
AaronMeyers opened this issue Feb 28, 2018 · 2 comments
Closed

Arc apps on Ansible don't ever clear the LEDs #35

AaronMeyers opened this issue Feb 28, 2018 · 2 comments

Comments

@AaronMeyers
Copy link
Contributor

@AaronMeyers AaronMeyers commented Feb 28, 2018

I just noticed that with the latest libavr32, the arc apps (Cycles, Levels) on Ansible seem to never clear the LEDs which makes them pretty much impossible to use. I managed to track down the commit where it starts happening: 89291aa

i couldn't build from the two commits from @boqs before that because the compiler had some errors, but the issue wasn't present before those commits.

Maybe it has something to do with this commit? c5a6cb1

@scanner-darkly
Copy link
Member

@scanner-darkly scanner-darkly commented Feb 28, 2018

yeah, this is due to c5a6cb1 change.

this line doesn't have the intended effect anymore:
https://github.com/monome/ansible/blob/master/src/ansible_arc.c#L932

it should be changed to memset(monomeLedBuffer,0,MONOME_MAX_LED_BYTES);

there are several places in there that need to be changed. ansible_grid.c from a quick look just uses 128 but i would check it as well.

@tehn
Copy link
Member

@tehn tehn commented Mar 1, 2018

@tehn tehn closed this Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants