Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teletype 2.0 changes #26

Merged
merged 10 commits into from May 17, 2017
Merged

Teletype 2.0 changes #26

merged 10 commits into from May 17, 2017

Conversation

@samdoshi
Copy link
Contributor

@samdoshi samdoshi commented May 8, 2017

Mainly just some small additions and changes.

  1. Initialise app_event_handlers to be an array of handler_Ignore, which means that unhandled events will not cause crashes

  2. Add events and support for USB memory sticks

  3. Add timer pause and resume functions

Plus some other smaller tweaks.


Unfortunately this breaks all the modules, due to none of them compiling msc.c or being able to find msc.h.

Here are the PRs to fix that:

I'll do the Trilogy modules once this, the Teletype and the Ansible changes are merged.

samdoshi added 3 commits May 16, 2017
instead use timers_pause() and timers_resume() which track nesting
@tehn tehn merged commit c594713 into monome:master May 17, 2017
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@ngwese

This comment has been minimized.

Copy link
Member

@ngwese ngwese commented on src/arp.c in 85fdd92 May 17, 2017

If I'm understanding things correctly the changes to timers_pause/resume now disable both app and ui priority interrupts. The gives me the impression that we are no longer really making a distinction between app and ui?

This change is safe in that it is more protective than needed but the blurring of app and ui priority levels might be undesirable if/when the aleph codebase is moved to libavr32 (the seems to be some movement on that).

This comment has been minimized.

Copy link
Contributor Author

@samdoshi samdoshi replied May 17, 2017

timers_pause / timers_resume only work with APP_TC_IRQ_PRIORITY. It's just that they track nested levels too.

The major bug fix is really in timers_remove, the early return in it doesn't re-enable the timer.

This comment has been minimized.

Copy link
Contributor Author

@samdoshi samdoshi replied May 17, 2017

Just a bit more info, the inspiration for the fix is from your fix to the Aleph codebase, but's just for timers. More here

@samdoshi samdoshi deleted the samdoshi:teletype branch Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants