Teletype 2.0 changes #26
Merged
Conversation
stops undefined handlers from crashing
This was referenced May 8, 2017
instead use timers_pause() and timers_resume() which track nesting
This comment has been minimized.
This comment has been minimized.
|
If I'm understanding things correctly the changes to timers_pause/resume now disable both app and ui priority interrupts. The gives me the impression that we are no longer really making a distinction between app and ui? This change is safe in that it is more protective than needed but the blurring of app and ui priority levels might be undesirable if/when the aleph codebase is moved to libavr32 (the seems to be some movement on that). |
This comment has been minimized.
This comment has been minimized.
|
The major bug fix is really in |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Mainly just some small additions and changes.
Initialise
app_event_handlersto be an array ofhandler_Ignore, which means that unhandled events will not cause crashesAdd events and support for USB memory sticks
Add timer pause and resume functions
Plus some other smaller tweaks.
Unfortunately this breaks all the modules, due to none of them compiling
msc.cor being able to findmsc.h.Here are the PRs to fix that:
I'll do the Trilogy modules once this, the Teletype and the Ansible changes are merged.