refactor i2c

[scanner-darkly]

• fixed addresses (addresses are 7 bit, not 8 bit, cleared MSB)
• split commands
• added comments / reformatted

see https://llllllll.co/t/teletype-i2c-protocol/13642 for discussion

[scanner-darkly]

@tehn @catfact @trentgill please take a look

[scanner-darkly]

Travis build failed due to older firmwares needing to be updated to be used with the latest libavr32

[tehn]

thanks for pointing this out.

i'm good for a more radical re-assignment of the monome stuff. ie

WW 0x10
MP 0x11
ES 0x12

and there's not a great reason that there are even-numbered addresses for ansible modes. not sure what my rationale was earlier.

[scanner-darkly]

that would mean newer versions of teletype wouldn't be backwards compatible and would require updating all the other firmwares as well - perhaps more trouble than it's worth?

[tehn]

oy if course you’re correct!

…

On Sun, May 13, 2018 at 10:14 PM scanner-darkly ***@***.***> wrote: that would mean newer versions of teletype wouldn't be backwards compatible and would require updating all the other firmwares as well - perhaps more trouble than it's worth? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#36 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPEcJWPvQkYHCLeR2Do-BPDeSbXOEtlks5tyOh_gaJpZM4T8mK6> .

[trentgill]

I believe 'only even addresses' was because we thought it was left-aligned 7bit number?
Regardless this seems like a positive change as it won't break anything, and means the code reflects what is happening on a hardware level.
I will update the JF & W/ repos which will make those defines a lot more meaningful!

[bpcmusic]

Thanks for taking the lead on this, @scanner-darkly. You really are the best!

It looks like we need to add in the range for the TELEX modules (0x60-0x6F), fix the conflict with the 16n (FADER), fix the conflict with the ER-301, and add in the tentative addresses for the Tetrapad integration that I've proposed in specification with kisielk. I'll suggest some things over on the forum shortly.

[scanner-darkly]

@bpcmusic - sorry, should've tagged you in this PR! i'll do another commit to include your changes.

[scanner-darkly]

@bpcmusic added your changes, i expanded the names to avoid potential conflicts, let me know if they look okay. er-301 change will be in a separate PR.

[scanner-darkly]

@bpcmusic @tehn are we good to merge this?

[tehn]

looks great!

[bpcmusic]

I'll test tomorrow with the latest; apologies for not responding sooner. I've been in SMD hell this weekend and am still half-delirious from the fumes. Thx@

[scanner-darkly]

@bpcmusic no worries, i need to do another pull request for the er-301 changes and figured i could just add any other required changes there. would you need an updated teletype firmware for testing? i’ll update my tt branch to use this version tomorrow.