Legacy adapter for varibright `/level` messages #44
Conversation
|
Say whaaaaaaat
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is a (mostly) working proof-of-concept to provide older devices with some LED feedback for the varibright
/led/level/**OSC messages.Right now, it's only implemented for
series, but it could be pretty easily added to 40h.I'm not 100% sure how accurate it is in the bitmapping stage:
/grid/led/level/rowand/grid/led/level/colseem to do the right thing, but/grid/led/level/mapis drawing upside down.There's also a somewhat arbitrary decision here to use the 50% point as the threshold (i.e. anything "low intensity" stays off, and anything "medium" or "high" intensity turns on). It might make more sense to make this configurable, so it could be set by serialosc, and therefore by a serialosc config on a per-device basis.