posix: don't process events when read returns < 0 #48
Conversation
|
Nope, looks good to me. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
i'm using libmonome to read directly from a serial device on linux.
much to my surprise, at a certain point in the project i started getting segfaults and spurious callbacks on device disconnect, which i never saw before.
currently my test device is a latest-edition 128.
after digging a bit, i found that
next_event()is returning-1(ultimately from here), but the event loop just checks for logical zero, so it continues with a bogus event structure, which may or may not blow up spectacularly.here's a minimal patch that works for me, but maybe there's a better solution