Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter .DS_Store or others from maiden menus #110

Closed
okyeron opened this issue Jun 14, 2018 · 9 comments
Closed

filter .DS_Store or others from maiden menus #110

okyeron opened this issue Jun 14, 2018 · 9 comments

Comments

@okyeron
Copy link

@okyeron okyeron commented Jun 14, 2018

I started using Transmit today (from my Mac) to sftp to norns and now I'm seeing the invisible files ".DS_Store" and "._.DS_Store" in my maiden menu listings. (also using SAMBA, so I'm not sure which one is generating those DS_Store files)

I suppose these invisible files just need to be filtered out of the list?

screen shot 2018-06-14 at 3 11 50 pm

@phonk
Copy link

@phonk phonk commented Jul 17, 2018

seconded. Not really an important functionality but it ruins a bit Maiden's elegance.

@ngwese
Copy link
Member

@ngwese ngwese commented Jul 19, 2018

this shouldn’t be too bad to add. will look into it

@nf
Copy link
Contributor

@nf nf commented Jul 19, 2018

It could make sense to just filter out all dotfiles. I volunteer to do this, if that's what we want to do.

@okyeron
Copy link
Author

@okyeron okyeron commented Feb 24, 2019

Wanted to ping this topic again -
Noticed today that the .git directory shows up in subdirectories

Also - what to do about readme.md files? Probably leave them visible?

@simonvanderveldt
Copy link
Member

@simonvanderveldt simonvanderveldt commented Feb 24, 2019

Is there no way to exclude what you're sending to norns in the tool you're using?

@tehn
Copy link
Member

@tehn tehn commented Feb 24, 2019

@simonvanderveldt
Copy link
Member

@simonvanderveldt simonvanderveldt commented Feb 24, 2019

No chance someone wants to store something in a .dot dir and wants to edit that?

@ngwese
Copy link
Member

@ngwese ngwese commented Feb 24, 2019

This ticket should be addressed by this change once it is merged.
747e828

UPDATE: re editing files in dot directories. I’m not to worried about that - folks placing stuff in dot directories or naming files with a dot probably know what they are doing and can edit those files via a different mechanism than maiden. That said I should probably add validation to prevent people from renaming files starting with a ‘.’

@ngwese
Copy link
Member

@ngwese ngwese commented Mar 4, 2019

Fixed as of 747e828

@ngwese ngwese closed this Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants