Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file rename occasionally fails to update browser file state #127

Closed
ngwese opened this issue Jul 6, 2018 · 1 comment
Closed

file rename occasionally fails to update browser file state #127

ngwese opened this issue Jul 6, 2018 · 1 comment
Labels
bug

Comments

@ngwese
Copy link
Member

@ngwese ngwese commented Jul 6, 2018

it appears that occasionally after renaming a file in maiden it is no longer possible to play the file.
https://llllllll.co/t/norns-help/14016/268
https://llllllll.co/t/norns-help/14016/269

refreshing the browser window appears to fix the problem.

given the behavior it is likely that the rename operation was completed on the device (via the http backend) and the return response is either:

  • an error which would cause maiden to not update its local state with the renamed file/url
  • the rename logic for the buffer file tree state in the maiden isn't finding the matching node to update.

refreshing the browser window is effectively forcing the on device file tree to be re-read which seem to be further evidence that the change is made on device but the browser based data is not being brought in sync.

@ngwese ngwese added the bug label Jul 6, 2018
@ngwese
Copy link
Member Author

@ngwese ngwese commented Apr 7, 2019

this should be fixed as of 30c76e3

@ngwese ngwese closed this Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant