monome / norns-community

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create github action to syntax check changes #22

Closed

ngwese opened this issue Mar 10, 2020 · 1 comment

Assignees

Member

ngwese commented Mar 10, 2020

there have been a few instances where changes have introduced syntax errors in the JSON files which cause weird failures such as: https://llllllll.co/t/norns-maiden/14052/131?u=ngwese

we should be able to set things up such that syntax validation is required in order to merge.

ngwese self-assigned this

Member Author

ngwese commented Mar 10, 2020

setup and tested, specifically:

github action to perform json schema validation (more than just syntax checking) has been defined
master branch protection which requires:
- incoming branch is up to date with master
- validation checks pass before merge

ngwese closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment