Skip to content

/ norns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrub the menu system for dependence on globals containing modules #1288

Closed
ngwese opened this issue Jan 1, 2021 · 0 comments
Closed

Scrub the menu system for dependence on globals containing modules #1288

ngwese opened this issue Jan 1, 2021 · 0 comments

Comments

@ngwese
Copy link
Member

@ngwese ngwese commented Jan 1, 2021

As reported here: https://llllllll.co/t/maiden-cannot-load-scripts-with-exception/399 assigning a value to tab breaks script loading and possibly other things. (potentially no longer an issue due changes from #1285)

It seems prudent to take a pass over the lua code in core and make sure any library/modules it is dependent on (such as tabutil) are locally imported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

stray nonlocal tabs
1 participant
@ngwese