Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control / number param interface #284

Closed
catfact opened this issue May 2, 2018 · 3 comments
Closed

control / number param interface #284

catfact opened this issue May 2, 2018 · 3 comments
Labels

Comments

@catfact
Copy link
Collaborator

@catfact catfact commented May 2, 2018

trying to use paramset, having to make a lot of switches on parameter type (tNUMBER vs tCONTROL) and call different methods. would it not make sense to give the two types the same interface

number: minval, maxval, set
corresponds to
control: min, max, set_raw

^ and incidentally, control.set vs control.raw_set seems unintuitive / ambiguous?
set should be the most commonly used, yeah? which would be, setting unmapped value and triggering update.,
for clarity, would recommned set_mapped, set_unmapped and set as alias to set_unmapped.


and, just curious - when would you expect to use a tNUMBER instead of a tCONTROL?

@artfwo
Copy link
Member

@artfwo artfwo commented May 19, 2018

currently number increases in steps of 1, and control in steps of (max-min)/100.

@tehn
Copy link
Member

@tehn tehn commented May 19, 2018

the delta mechanism is actually the sole reason for NUMBER vs CONTROL.

ie. "tempo" wants delta changes of 1, not 1/100 increments of an arbitrary range from 40-240.

we could otherwise have a flag for CONTROL to do non-mapped delta

re: minval, maxval yes these should just be renamed

@tehn
Copy link
Member

@tehn tehn commented Jun 10, 2019

set_mapped and set_unmapped are much more intuitive.

i think we can make this work w/o it being breaking?

@tehn tehn closed this Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants