Skip to content

/ norns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable acceleration (or reduce it) within menu #376

Closed
tehn opened this issue May 25, 2018 · 8 comments
Closed

disable acceleration (or reduce it) within menu #376

tehn opened this issue May 25, 2018 · 8 comments
Assignees
@tehn
Labels
menu
Milestone
1.0.2

Comments

@tehn
Copy link
Member

@tehn tehn commented May 25, 2018

way too twitchy
@tehn tehn added the menu label May 25, 2018
@tehn tehn self-assigned this May 25, 2018
@simonvanderveldt
Copy link
Member

@simonvanderveldt simonvanderveldt commented May 25, 2018

Without the knobs it was pretty annoying, but I haven't really had any issues since I put the knobs on.
Does it skip over the menu items too quickly for you?
@tehn
Copy link
Member Author

@tehn tehn commented May 25, 2018

it's particularly twitchy with long lists like system > audio
@nf
Copy link
Collaborator

@nf nf commented Jul 10, 2018

I'm happy to take a crack at fixing this.
@pq
Copy link
Collaborator

@pq pq commented Jul 10, 2018

iirc should make for an easy tweak in menu.lua.

norns/lua/menu.lua

Lines 305 to 308 in 7c553e4

norns.encoders.set_accel(0,true)
norns.encoders.set_sens(1,1)
norns.encoders.set_sens(2,0.5)
norns.encoders.set_sens(3,0.5)

nf added a commit to nf/norns that referenced this issue Jul 10, 2018
@nf
Disable acceleration within menu
46bdd0c 
This is a definite improvement, if not a fine solution.
Tested navigating through very long and very short menus alike,
and it seems good.

Issue monome#376
@nf nf mentioned this issue Jul 10, 2018
Closed
@nf
Copy link
Collaborator

@nf nf commented Jul 10, 2018

Thanks @pq, that was the spot.

I disabled acceleration and it did the trick for me. I'm sure further tweaks should be made, but this is a step in the right direction.
@catfact catfact closed this Aug 5, 2018
@antonhornquist
Copy link
Collaborator

@antonhornquist antonhornquist commented Aug 6, 2018

@nf fix is mot merged
@antonhornquist antonhornquist reopened this Aug 6, 2018
adg added a commit to nf/norns that referenced this issue Aug 6, 2018
@nf @adg
Disable acceleration within menu
d4ae5ab 
This is a definite improvement, if not a fine solution.
Tested navigating through very long and very short menus alike,
and it seems good.

Issue monome#376
@nf nf mentioned this issue Aug 6, 2018
Merged
adg pushed a commit to nf/norns that referenced this issue Aug 6, 2018
@nf
Disable acceleration within menu
a514063 
This is a definite improvement, if not a fine solution.
Tested navigating through very long and very short menus alike,
and it seems good.

Issue monome#376
@tehn tehn added this to the 1.0.2 milestone Aug 14, 2018
@tehn
Copy link
Member Author

@tehn tehn commented Aug 14, 2018

#480
@tehn tehn closed this Aug 14, 2018
@tehn tehn reopened this Aug 14, 2018
@tehn
Copy link
Member Author

@tehn tehn commented Aug 14, 2018

acceleration should be enabled for LEVELS screen (so all faders will react the same)
@tehn tehn mentioned this issue Aug 14, 2018
Merged
@tehn tehn closed this in #493 Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tehn tehn

Labels
menu
Projects
None yet
Milestone
1.0.2
Linked pull requests

Successfully merging a pull request may close this issue.

various minor fixes
6 participants
@antonhornquist @pq @nf @catfact @simonvanderveldt @tehn