Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default input gain (hardware) #418

Closed
catfact opened this issue Jun 10, 2018 · 6 comments
Closed

default input gain (hardware) #418

catfact opened this issue Jun 10, 2018 · 6 comments
Labels

Comments

@catfact
Copy link
Collaborator

@catfact catfact commented Jun 10, 2018

while debugging some stuff, i realized that the input gains on my hardware are really different for each channel. i don't know if this is normal.

i also noticed:

  • the i2c settings are all exposed in weaver, but not all are mapped to lua modules. in particular gain_in is not.
  • i don't know the correct range for levels. 50 seemed reasonable for me.
  • the order of args (level, channel) is opposite from basically everywhere else.
  • this should maybe be set to some default, and/or exposed as a system parameter?
@catfact catfact added the question label Jun 10, 2018
@tehn
Copy link
Member

@tehn tehn commented Jun 10, 2018

you have a prototype right now-- the i2c-controlled gain stage was removed on the production units.

the solution for prototypes is to have the levels set to unity at startup by the init scripts. i thought @simonvanderveldt and i fixed this a couple months ago, but perhaps recent images lost the i2c setup (given it's used by just a couple units out there now)

@tehn tehn closed this Jun 10, 2018
@simonvanderveldt
Copy link
Member

@simonvanderveldt simonvanderveldt commented Jun 10, 2018

@tehn The commands are still there, just prefixed with a - so they won't fail the unit https://github.com/monome/norns-image/blob/master/config/norns-init.service#L11

@catfact Did the norns-init unit run correctly for you?

@catfact
Copy link
Collaborator Author

@catfact catfact commented Jun 10, 2018

ah -sorry - i don't know. i'll check.

so @tehn can we remove the lua bindings for these hardware commands that aren't in the hardware anymore? can just set stuff from shell for protos right?

@tehn
Copy link
Member

@tehn tehn commented Jun 10, 2018

yes we can, and should. i apologize for not pulling them out sooner.

@simonvanderveldt
Copy link
Member

@simonvanderveldt simonvanderveldt commented Jun 11, 2018

@catfact Sorry, I missed the input part of the issue title, the link I posted goes to the commands for output.

The commands for the gain of the inputs are still in the unit but commented out https://github.com/monome/norns-image/blob/master/config/norns-init.service#L15
@tehn just to be sure: the gain staging was removed from both inputs and outputs?

@tehn
Copy link
Member

@tehn tehn commented Jun 11, 2018

correct. no i2c gain on input or output anymore for production units.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants