Skip to content

/ norns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Releases should not contain loom.data #601

Closed
markwheeler opened this issue Oct 13, 2018 · 1 comment
Closed

Releases should not contain loom.data #601

markwheeler opened this issue Oct 13, 2018 · 1 comment

Comments

@markwheeler
Copy link
Collaborator

@markwheeler markwheeler commented Oct 13, 2018

The file dust/data/mark_eats/loom.data seems to overwrite a user's previously saved loom data, so I think it should be removed from release (it is present in 181008). I don't see it in the dust repo and I'm not totally clear on how updates decide what to overwrite vs keep.

We do however need to have at least an empty folder at dust/data/mark_eats so that Loom has a place to save to. I see there is a default pmap file in the release, should I add that to the dust repo?
@markwheeler
Copy link
Collaborator Author

@markwheeler markwheeler commented Oct 23, 2018

Closing this - seemed like it happened in 181008 but 181023 is a-ok.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@markwheeler