Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine list report not getting called #798

Closed
tehn opened this issue Apr 4, 2019 · 3 comments
Closed

engine list report not getting called #798

tehn opened this issue Apr 4, 2019 · 3 comments
Assignees
Labels
bug

Comments

@tehn
Copy link
Member

@tehn tehn commented Apr 4, 2019

noticed that engine.names is empty

https://github.com/monome/norns/blob/dev/matron/src/weaver.c#L1625

calling report_engines() bonks


was attempting to do a check on engine.name for scripts against available engines to warn the user if the engine is missing instead of just failing poorly

@tehn tehn added the bug label Apr 4, 2019
@catfact catfact self-assigned this Apr 8, 2019
@catfact
Copy link
Collaborator

@catfact catfact commented Apr 9, 2019

@tehn interesting... i didn't have this problem with we at commit a7c1943b5c1e1316f8dbedeffce93b8564fe7f50 (april 1) and norns at current master.

then i pulled we/master just now (april 8) and got the crash/hang in matron apparently. breaking out the debugger...

@tehn
Copy link
Member Author

@tehn tehn commented Apr 9, 2019

good chance i broke something when touching (theoretically cleaning up) a lot of weaver bits while i was implementing softcut glue. i can take a look later tonight.

@tehn
Copy link
Member Author

@tehn tehn commented Apr 15, 2019

fixed by #808

@tehn tehn closed this Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants