Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

softcut: buffer-clear commands are slow / stall OSC thread #805

Closed
catfact opened this issue Apr 7, 2019 · 3 comments
Closed

softcut: buffer-clear commands are slow / stall OSC thread #805

catfact opened this issue Apr 7, 2019 · 3 comments
Assignees
Labels
bug

Comments

@catfact
Copy link
Collaborator

@catfact catfact commented Apr 7, 2019

from lines (https://llllllll.co/t/cranes/21207/8?u=zebra)

[quote="Dan_Derks, post:8, topic:21207"]

occasionally when recording (even when on a brand new instance) i get phantom little echos of whatever im recording that appear WHILE i’m recording

ah. while updating this script, i found that the order of softcut’s buffer-clearing and reset commands seem to matter, but i’m still not entirely sure what order is best. i landed on this version after extensive command juggling and while it has not exhibited this behavior on my machine since then, i think i know what you’re describing. it’s like the playhead somehow gets engaged just a few ms behind the write head, yeah?
[/quote]

i suspect this might be due to the fact that buffer clear commands are executed directly from OSC handler thread, and they are relatively heavy. so could be delaying the execution of subsequent commands or something.

one simple thing to try is just slapping some worker threads in there.

@catfact catfact changed the title softcut: buffer-clear commands are slow, or something softcut: buffer-clear commands are slow / stall OSC thread Apr 7, 2019
@catfact catfact added the bug label Apr 7, 2019
@catfact catfact self-assigned this Apr 7, 2019
@catfact
Copy link
Collaborator Author

@catfact catfact commented Apr 9, 2019

pushed branch with worker threads, still basically untested
https://github.com/monome/norns/tree/softcut-buffer-workers

also: we are seeking each frame on buffer read! too slow
https://github.com/monome/norns/blob/master/crone/src/SoftCutClient.cpp#L219

@itsyourbedtime
Copy link
Contributor

@itsyourbedtime itsyourbedtime commented Apr 13, 2019

nvm, usererror =)

@catfact
Copy link
Collaborator Author

@catfact catfact commented Nov 17, 2019

closing, replaced by #934

@catfact catfact closed this Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants