Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

softcut reset #812

Closed
tehn opened this issue Apr 9, 2019 · 10 comments
Closed

softcut reset #812

tehn opened this issue Apr 9, 2019 · 10 comments
Assignees
Labels
lua
Milestone

Comments

@tehn
Copy link
Member

@tehn tehn commented Apr 9, 2019

https://github.com/monome/norns/blob/master/lua/core/softcut.lua#L153

this needs way more default settings (ie filter)

this function gets called when scripts are loaded.

@tehn tehn added the lua label Apr 9, 2019
@tehn tehn self-assigned this Apr 9, 2019
@simonvanderveldt
Copy link
Member

@simonvanderveldt simonvanderveldt commented Apr 10, 2019

Is there no reset message or something along those lines to reset softcut?

@catfact
Copy link
Collaborator

@catfact catfact commented Apr 11, 2019

there is - it's linked above - it simply needs to touch quite a few more parameters.

@simonvanderveldt
Copy link
Member

@simonvanderveldt simonvanderveldt commented Apr 11, 2019

@catfact Ah, OK. I expected there to be something on the non-lua side, that would then get called from the lua side.

@tehn tehn mentioned this issue Apr 12, 2019
@tehn tehn closed this in #813 Apr 14, 2019
@tehn
Copy link
Member Author

@tehn tehn commented Jul 8, 2019

need to implement a single OSC message to reset crone to softcut defaults, as currently it requires a massive amount of packets.

@tehn tehn reopened this Jul 8, 2019
@tehn tehn added this to the 2.1.0 milestone Jul 8, 2019
@catfact catfact assigned catfact and unassigned tehn Jul 8, 2019
@catfact
Copy link
Collaborator

@catfact catfact commented Jul 8, 2019

i'll do it. the clean way involves a bit of dancing between client, effect and voice classes

@catfact
Copy link
Collaborator

@catfact catfact commented Jul 8, 2019

one wrinkle about this is that it's probably a good idea to still have a lua reset that returns a state object reflecting the default state of the underlying audio process

@tehn
Copy link
Member Author

@tehn tehn commented Jul 8, 2019

i figure this should only be really used for script clear/startup so wondering how important it is?

@catfact
Copy link
Collaborator

@catfact catfact commented Jul 8, 2019

i won't sweat it, but it seems wise to at least document stuff like what voices are assigned to what buffers, instead of just magic stuff in the .cpp

@catfact
Copy link
Collaborator

@catfact catfact commented Jul 8, 2019

actually i'll just add it to the lua since it is totally trivial anyway

@tehn
Copy link
Member Author

@tehn tehn commented Jul 11, 2019

fixed by #856

@tehn tehn closed this Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants