Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crone/softcut: add / rename smoothing parameters. #876

Closed
catfact opened this issue Sep 8, 2019 · 2 comments
Closed

crone/softcut: add / rename smoothing parameters. #876

catfact opened this issue Sep 8, 2019 · 2 comments
Labels

Comments

@catfact
Copy link
Collaborator

@catfact catfact commented Sep 8, 2019

in crone mixer client, smoothing is applied to routing levelsand pan (MixerClient::smoothLevels structure.) but there are no parameters to change the smoothing time constant. a couple people have asked about adding these.

similarly, there is smoothing on output level and pan for each softcut voice, also with fixed timing. more confusingly, there is a levelSlew parameter which only controls recoruld/erase levels.

it's easy to add these parameters.
is it a good idea?
should we rename existing softcut slew params?
should a single param control all mixer slew times?
&c

@lpgitadmin
Copy link

@lpgitadmin lpgitadmin commented Sep 9, 2019

Slew on output level and on panning of a voice would be welcome from my point of view.

Name wise softcut.rate_slew_time makes total sense while currently softcut.level_slew_time is confusing.

@tehn
Copy link
Member

@tehn tehn commented Sep 9, 2019

smoothed level/pan on softcut voices makes for some fun modulation and sound design... initial tests were easy and satisfying

@tehn tehn closed this in #877 Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants