Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up softcut buffer management #934

Closed
catfact opened this issue Nov 3, 2019 · 1 comment
Closed

clean up softcut buffer management #934

catfact opened this issue Nov 3, 2019 · 1 comment
Assignees
Labels

Comments

@catfact
Copy link
Collaborator

@catfact catfact commented Nov 3, 2019

audio buffer save and load should be handled by main or dedicated worker thread in crone.
presently, buffer operations are performed directly in OSC handler,
which is bad because it blocks the handling of other commands.

  • request class (timestamp, filename)
  • worker thread (or main loop) and work Q (abstraction?)
  • completion handler (lua)
  • test / example script

while we're at it, some improvments to buffer read/write routines are in order:

  • read/write larger blocks
  • check libsndfile wrap/clip behavior for f32->s24 OOB values
@catfact
Copy link
Collaborator Author

@catfact catfact commented Jan 21, 2020

i'm calling this done for now. disk workers seem to be doing the job.

if we want callbacks to lua on job completion, that's pretty easy to add, but maybe i'll wait for a use case.

@catfact catfact closed this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant