Skip to content

/ norns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ableton link clock module #1032

Merged
merged 19 commits into from Mar 25, 2020
Merged

add ableton link clock module #1032

merged 19 commits into from Mar 25, 2020

Conversation

@artfwo
Copy link
Member

@artfwo artfwo commented Mar 14, 2020

No description provided.

artfwo added 7 commits Mar 14, 2020
@artfwo
add ableton link clock module
4574b31
@artfwo
Merge branch 'master' into clock-link
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1f1e4b9
@artfwo
add CLOCK_SOURCE_LINK to clock_source_t
657b4be
@artfwo
add --enable-ableton-link configure flag
Loading status checks…
5f0bb56
@artfwo
build link as static lib
Loading status checks…
9aea299
@artfwo
use link if enabled
da660e4
@artfwo
add link to clock.lua
Loading status checks…
f60c24a
@tehn
Copy link
Member

@tehn tehn commented Mar 14, 2020

rad!!
artfwo added 11 commits Mar 15, 2020
@artfwo
unconditionally update reference clock from link
07fb43c
@artfwo
compile link support only if enabled
Loading status checks…
68479ff
@artfwo
bump link-c
b0796ea
@artfwo
add set_quantum to clock_link
71f0692
@artfwo
lock shared link data
97ac2f7
@artfwo
add clock_link_set_tempo
3a72518
@artfwo
set link tempo at current host time
fb4f105
@artfwo
add clock.get_tempo
fb5716e
@artfwo
weaver for clock_link_set_tempo
e38cd54
@artfwo
weaver for clock_link_set_quantum
e3caf8c
@artfwo
remove unused code from clock.lua
3ec3d2c
@artfwo artfwo changed the title wip: add ableton link clock module add ableton link clock module Mar 22, 2020
@artfwo artfwo requested review from tehn, ngwese and catfact Mar 22, 2020
@artfwo
Merge branch 'master' into clock-link
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2ccc808
@ngwese
Copy link
Member

@ngwese ngwese commented Mar 22, 2020

excited to test this out! hopefully in the next few days.
@artfwo
Copy link
Member Author

@artfwo artfwo commented Mar 22, 2020 •
edited

test script used in the video:

https://gist.github.com/artfwo/a0224ba7fc84792648d7924398c4f59a
@catfact
catfact approved these changes Mar 25, 2020
View changes
Copy link
Collaborator

@catfact catfact left a comment

i don't have an easy way to test link stuff but code lgtm
@tehn
Copy link
Member

@tehn tehn commented Mar 25, 2020

happy to merge this into master so we can get some help testing ahead of documentation and examples. figure it's safe given it doesn't present breaking changes?

i can test once i knock out these new issues which came up from the recent update

super work @artfwo !
@artfwo
Copy link
Member Author

@artfwo artfwo commented Mar 25, 2020

alright, i'm gonna merge it then and go ahead with the playback sync features, also hopefully will write a better testing app this weekend.
@artfwo artfwo merged commit ad176cd into master Mar 25, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@artfwo artfwo deleted the clock-link branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catfact catfact

@tehn tehn

@ngwese ngwese

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@artfwo @tehn @ngwese @catfact