Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter crow/midi input #1089

Merged
merged 1 commit into from Apr 18, 2020
Merged

filter crow/midi input #1089

merged 1 commit into from Apr 18, 2020

Conversation

@tehn
Copy link
Member

@tehn tehn commented Apr 15, 2020

fixes #1088

basically rewrote the averaging function somewhat needlessly, as the primary fix was tiny.

the main improvement is filtering out huge values: infer a clock stop/start.

@tehn tehn requested a review from artfwo Apr 15, 2020
@artfwo
Copy link
Member

@artfwo artfwo commented Apr 17, 2020

@tehn, why does this skip updating reference if clock_midi_last_tick_time_set == false?

@tehn
Copy link
Member Author

@tehn tehn commented Apr 17, 2020

@tehn, why does this skip updating reference if clock_midi_last_tick_time_set == false?

it made more sense to me to wait until the second tick so that an actual time is submitted, rather than using a dummy time for the first tick.

@artfwo
artfwo approved these changes Apr 18, 2020
Copy link
Member

@artfwo artfwo left a comment

right, good to go!

@tehn tehn merged commit e31a9e1 into master Apr 18, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tehn tehn deleted the clock-in-filter branch Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants