Skip to content

/ norns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix crow.connected() always returning false #1128

Merged
merged 1 commit into from May 31, 2020
Merged

fix crow.connected() always returning false #1128

merged 1 commit into from May 31, 2020

Conversation

@csboling
Copy link
Contributor

@csboling csboling commented May 31, 2020

crow.connected() would always return false, since there is never a value assigned to _norns.crow.dev (should be norns.crow.dev). Reported here.
@csboling
fix crow.connected() always returning false
Loading status checks…
9f65e6f
@tehn
tehn approved these changes May 31, 2020
View changes
@tehn tehn merged commit 66733fb into monome:master May 31, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@csboling csboling deleted the csboling:crow-connected-func branch May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehn tehn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@csboling @tehn