add input quantum + wrap to controlspec, add wrap to number param #1149
Conversation
|
this is fantastic, thank you. it makes so much sense to use a table initializer for controldefs, and the i agree on renaming |
Addressed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #1144
Adds a
quantumarg to controlspec which is used to define the fraction of the value range thatparams:deltaadjusts by, rather than this being fixed at 1% of the range.It is also sometimes useful to have params with values that wrap around rather than clamping, e.g. angles -- this is the case for the script I'm currently working on which is why I started messing with this. Added a
wrapoption to bothcontrolandnumberparams.Since this winds up being a lot of args on
ControlSpec.newnow I added aControlSpec.defmethod which accepts a table -- I looked around a bit but I'm not sure what if any naming convention exists for positional vs keyword-argument style constructors. The table args forControlSpec.defareminandmaxfor consistency withparams:add, rather thanminvalueandmaxvalueas the positional args are named. Perhaps the positional args should be changed tominandmaxfor clarity of the luadocs?Test script for all the new functionality: