Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create tape dir on record, if the user has deleted it #1222

Merged
merged 1 commit into from Nov 2, 2020

Conversation

@catfact
Copy link
Collaborator

@catfact catfact commented Nov 2, 2020

not sure if this is really desired, but:

  • currently, there is a check for nil file handle to audio/tape/index.txt when reading to increment tape filename.
  • however, there is no analogous check for nil when writing to the same file a few lines later.

it is possible to run into this if a user deletes their audio/ or audio/tape/. (why would they do this? don't ask me. but it happened and this burned some support time.)

so this change creates ~/dust/audio/tape/ and parents before writing the index file, if the initial attempt results in a nil handle.

@tehn
tehn approved these changes Nov 2, 2020
@tehn tehn merged commit 6e0842f into monome:main Nov 2, 2020
@catfact catfact deleted the catfact:create-tape-dir-if-needed branch Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants