PMAP autosave + 16 MIDI vports

[dndrks]

PMAP auto-save

params.lua

previous behavior:

• midi mappings (PMAPs) were only saved when a PSET was saved

new behavior:

• PMAPs are saved after they're assigned, so they persist between script loads without needing to save a PSET

16 MIDI vports

previous behavior:

• norns could host up to 16 MIDI devices, but only assigned devices to 4 MIDI vports
• SYSTEM > DEVICES > MIDI reflected only 4 MIDI vports
• users had to remove/reassign vport-assigned devices more often
• this removing/reassigning disrupted accuracy of mapped controls in PMAPs (which restores based on vport device ID)

new behavior:

• norns can now assign up to 16 MIDI vports to match its hosting capability
• users can manage all 16 vports via SYSTEM > DEVICES > MIDI
• 16 device history means users will have to do much less device management/rearranging
• restoring static vport device IDs via PMAPs is less problematic, unless the user purposefully rearranges their device

SYSTEM > DEVICES > MIDI:

assigned a connected device to a vport (up to 4 pages can generate, no indicator if only 1 page):

midi.lua

• create 16 MIDI vports (addresses #1260)

pmap.lua

• expect assignments from all 16 MIDI vports

state.lua

• remember devices from all 16 MIDI vports

devices.lua

• add menu redraw handling for 16 MIDI vports
• add m.last_pos to remember which port was last highlighted when switching back to port list from device list

clock.lua

• extended clock params table to include all 16 ports
• added naming (with abbreviations) to help make it easy for users to see port assignments
  
  nb. of course, names are refreshed only at boot, but i think this is helpful regardless. if a device's name is none, it just shows the port number.

show mapped device's name

params.lua

previous behavior: mapping a midi controller to a parameter showed only its port number
new behavior: midi map menu now shows the device's name (abbreviated if longer than 6 characters, eg. "Midi Fighter Twister" becomes "MFT"), which helps with clarity

fix #1261

home.lua

• added parameter menu reset

add util.acronym()

util.lua

• util.acronym() will return an acronym from a given string

eg. util.acronym("Midi Fighter Twister") returns MFT

[tehn]

rad! will check it out.

[tehn]

this is great! some minor inline comments to address but tested it out, nice attention to detail.

one big change i'd like you to tackle first, however, is you introduce a new scrolling/paging style for the device midi menu. i'd much prefer you make it conform the the existing style which is followed by the SELECT and PARAM lists: basically six lines displayed, highlight on line 3. for device/midi the minor mod to this would be MIDI on line 1, line 2 blank, then have lines 3-6 scrolling while keeping line 3 the highlight.

awesome work!

[dndrks]

@tehn + @ryanlaws , thank you for the detailed feedback!

i've aligned the nav mechanics of the DEVICES > MIDI device menu + submenu with the scrolling template of SELECT + PARAMETERS. i also touched up some of the legibility, as highlighted by your q's and comments.

lmk if this feels good and tests well!

[tehn]

code looks good, will test on device this afternoon!

[tehn]

little late--- this throws an error, and i'm wondering what the original intention was?

[dndrks]

mmm. dang. it was to avoid a screen redraw issue after clearing the script and returning to parameters (maybe to adjust the clock or fine-tune a global param in between script loads). i can take a peek later this week, sorry for the trouble!

…

On Mon, Dec 28, 2020 at 5:56 PM brian crabtree ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In lua/core/menu/home.lua <#1268 (comment)>: > @@ -24,6 +24,7 @@ m.key = function(n,z) else norns.script.clear() _norns.free_engine() + params.reset() little late--- this throws an error, and i'm wondering what the original intention was? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1268 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AF5L2HCGC6C3ZWJ6IFMWW5LSXELLPANCNFSM4UVSCGOA> .

[tehn]

ah i remember now! this is an easy fix i think. i'll get it