Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spaces in Wi-Fi network SSIDs and passwords #434

Merged
merged 1 commit into from Jun 24, 2018
Merged

Conversation

@Dewb
Copy link
Contributor

@Dewb Dewb commented Jun 23, 2018

I'm one of those unlucky people whose home wifi network has a space both in the network SSID and the password. This PR contains the following changes, which allow me to connect:

  • Adds a space character to textentry.lua. The space is rendered as a space; a good future enhancement might be to display some kind of dim _ character to make selecting and entering it clearer.
  • Quotes the network SSID and password arguments when calling wifi.sh select.
@Dewb
Copy link
Contributor Author

@Dewb Dewb commented Jun 23, 2018

Area of potential concern: I haven't put any thought yet into the implications of allowing spaces in all other uses of textentry.

@tehn
tehn approved these changes Jun 24, 2018
@tehn tehn merged commit 7d00b01 into monome:master Jun 24, 2018
@tehn
Copy link
Member

@tehn tehn commented Jun 24, 2018

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants