Support spaces in Wi-Fi network SSIDs and passwords #434
Conversation
|
Area of potential concern: I haven't put any thought yet into the implications of allowing spaces in all other uses of textentry. |
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I'm one of those unlucky people whose home wifi network has a space both in the network SSID and the password. This PR contains the following changes, which allow me to connect:
textentry.lua. The space is rendered as a space; a good future enhancement might be to display some kind of dim _ character to make selecting and entering it clearer.wifi.sh select.