it means that when running the code on a laptop, we get a lot of noise and confusion as norns attempts to use all the other TTY and HID devices. the subsystem check is there for the simple reason that we would like to ignore these and have a similar experience when testing norns code on laptop as on norns HW.
the change has no application to the norns hardware. i'm also failing to see how it has much application on other, hypothetical hardware - the entire point of device_monitor.c is to monitor hotplugged devices; if you are using some other hardware with persistent GPIO midi, why do you need to detect it?
all thatn said, i don't have a huge problem with merging this and skipping the subsystem checks, if anyone else sees a benefit.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.
see #527
expose non-usb midi devices e.g. gpio