Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device monitor return non-usb midi devices #532

Closed
wants to merge 1 commit into from

Conversation

@TheTechnobear
Copy link

@TheTechnobear TheTechnobear commented Aug 31, 2018

see #527

expose non-usb midi devices e.g. gpio

@catfact
Copy link
Collaborator

@catfact catfact commented Sep 1, 2018

i still don't like this:

  • it means that when running the code on a laptop, we get a lot of noise and confusion as norns attempts to use all the other TTY and HID devices. the subsystem check is there for the simple reason that we would like to ignore these and have a similar experience when testing norns code on laptop as on norns HW.

  • the change has no application to the norns hardware. i'm also failing to see how it has much application on other, hypothetical hardware - the entire point of device_monitor.c is to monitor hotplugged devices; if you are using some other hardware with persistent GPIO midi, why do you need to detect it?

all thatn said, i don't have a huge problem with merging this and skipping the subsystem checks, if anyone else sees a benefit.

@TheTechnobear
Copy link
Author

@TheTechnobear TheTechnobear commented Sep 1, 2018

ok, I'll withdraw
seems my use-cases are not relevant to norns.

@TheTechnobear TheTechnobear deleted the TheTechnobear:nonusbmidi branch Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants