Skip to content

/ norns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the right accessor union for key events, and fix comments #639

Merged
merged 1 commit into from Nov 12, 2018
Merged

use the right accessor union for key events, and fix comments #639

merged 1 commit into from Nov 12, 2018

Conversation

@catfact
Copy link
Collaborator

@catfact catfact commented Nov 12, 2018

minor broken-windows things:

  • posting key events was setting data fields as if they were enc events
  • comments describing event structure sizes were all rotted.
@catfact
use the right accessor union for key events, and fix comments
Loading status checks…
774ea61
@tehn
tehn approved these changes Nov 12, 2018
View changes
@tehn tehn merged commit 3939671 into monome:master Nov 12, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@catfact catfact deleted the catfact:events-broken-windows branch Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehn tehn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@catfact @tehn