Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for nil midi data bytes (active sensing, etc) #658

Merged
merged 2 commits into from Nov 25, 2018

Conversation

@okyeron
Copy link
Contributor

@okyeron okyeron commented Nov 25, 2018

bracket out of place -- status bytes 0xF8 and above were sending 2 chunks of event data, second one being nil.

okyeron okyeron
status bytes 0xF8 and above were sending 2 chunks of event data, second one being nil.
@okyeron okyeron changed the title fix for nil data bytes (active sensing, etc) fix for nil midi data bytes (active sensing, etc) Nov 25, 2018
Copy link
Member

@artfwo artfwo left a comment

ah, i see where the problem is now. looks good, but please fix code formatting. we are using 4 spaces for the indentation in c.

okyeron okyeron
@okyeron
Copy link
Contributor Author

@okyeron okyeron commented Nov 25, 2018

updated

@artfwo
artfwo approved these changes Nov 25, 2018
Copy link
Member

@artfwo artfwo left a comment

👍

@tehn tehn merged commit fd035ae into monome:master Nov 25, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants