monome / norns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove consumers of removed ugens #754

Merged

tehn merged 1 commit into dev from cleanup-sc-softcut

Mar 14, 2019

Member

simonvanderveldt commented Mar 14, 2019 •

edited

The removal of the ugens in #753 did cause a class not found error
See https://llllllll.co/t/norns-2-0-beta/20366/279

This PR removes the remaining pieces that still used it.

Questions:

Is this a problem for scripts users might already have on their device that haven't been updated? If so, how do we want to handle that situation?
The actual error is ERROR: Message 'ar' not understood. Does this relate to these changes as well?

[edit] Haven't tried this on device yet, still at work


          Remove consumers of removed ugens

ada47d8

simonvanderveldt requested review from catfact and tehn

tehn merged commit 26d2cd8 into dev

tehn deleted the cleanup-sc-softcut branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment