softcut buffer fixes #759
Merged
softcut buffer fixes #759
Conversation
|
oh, NB: as with |
|
aha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fixed a couple lua/OSC commands:
/softcut/buffer/clear: this was broken inSoftCutClient/softcut/buffer/clear_region_channel: this was broken inmatron/weaveradded:
/softcut/buffer/write_mono [sffi]; args: path, start (seconds), dur (seconds), channel (zero-based)/softcut/buffer/write_stereo [sff]; args: path, start (seconds), dur (seconds)for all the buffer functions,
dur=-1means to read/write/clear the entire buffer. (or, read the entire file if that is shorter.) (there is an attempt inOscInterface.cppto provide defaults for missing arguments, but it turns outliblodoesn't work this way and the handlers aren't called at all. so this should be cleaned up too.)have not yet added lua/weaver glue for write commands, nor tested on norns HW (only on desktop
cronewith raw OSC.)(happy to add glue and test sometime next week, unless someone else can get to it first.)
also:
cronesend some OSC back tomatronwhen these operations finish.