Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

softcut buffer fixes #759

Merged
merged 5 commits into from Mar 17, 2019
Merged

softcut buffer fixes #759

merged 5 commits into from Mar 17, 2019

Conversation

@catfact
Copy link
Collaborator

@catfact catfact commented Mar 16, 2019

fixed a couple lua/OSC commands:

/softcut/buffer/clear : this was broken in SoftCutClient
/softcut/buffer/clear_region_channel : this was broken in matron/weaver

added:

  • /softcut/buffer/write_mono [sffi]; args: path, start (seconds), dur (seconds), channel (zero-based)

  • /softcut/buffer/write_stereo [sff]; args: path, start (seconds), dur (seconds)

for all the buffer functions, dur=-1 means to read/write/clear the entire buffer. (or, read the entire file if that is shorter.) (there is an attempt in OscInterface.cpp to provide defaults for missing arguments, but it turns out liblo doesn't work this way and the handlers aren't called at all. so this should be cleaned up too.)

have not yet added lua/weaver glue for write commands, nor tested on norns HW (only on desktop crone with raw OSC.)

(happy to add glue and test sometime next week, unless someone else can get to it first.)

also:

  • both read and write are unnecessarily slow (1 frame at a time.)
  • it might be good to have crone send some OSC back to matron when these operations finish.
@catfact
Copy link
Collaborator Author

@catfact catfact commented Mar 16, 2019

oh, NB: as with Tape, output format is 24-bit fixed, 48k, wav. format is arbitrary; chose 24b instead of float as a compromise for the limited disk space on norns.

@catfact catfact requested a review from tehn Mar 16, 2019
@tehn
tehn approved these changes Mar 16, 2019
@tehn
Copy link
Member

@tehn tehn commented Mar 16, 2019

aha dur=-1 awesome, thank you! and file writing, wow. i can add the glue.

@catfact catfact merged commit 1bdb20d into dev Mar 17, 2019
tehn added a commit that referenced this pull request Mar 20, 2019
@tehn tehn mentioned this pull request Mar 20, 2019
tehn added a commit that referenced this pull request Mar 21, 2019
glue for #759
@catfact catfact deleted the softcut-buffer-fixes branch Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants