Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add worker threads for softcut buffer read/write/clear #811

Closed
wants to merge 1 commit into from

Conversation

@catfact
Copy link
Collaborator

@catfact catfact commented Apr 9, 2019

looking at issue #805

added worker threads from OSC handler functions for buffer read/write/clear.

this is untested. opening PR in case anyone wants to leave feedback before i can get around to it.

@catfact catfact added the do not merge label Apr 9, 2019
@catfact
Copy link
Collaborator Author

@catfact catfact commented May 21, 2019

hey, we should merge this. any softcut script authors want to verify that it doesn't break stuff?

seemed ok to me but i haven't tested extensively and don't typically use these functions in my scripts.

basically, you should be able to load / save buffer regions without holding up processing other crone OSC commands.

@catfact catfact requested a review from tehn May 21, 2019
@tehn
Copy link
Member

@tehn tehn commented May 21, 2019

crud, sorry! will test this tonight.

@tehn
Copy link
Member

@tehn tehn commented May 23, 2019

ok unfortunately having a hard time getting this to run properly.

  • branch is 64 commits behind master, so i merge master first (otherwise all sorts of other things are busted with phase polls)
  • crone is quitting at some point after startup. if i run it via start.sh i see
terminate called without an active exception

once the menu shows up.

launching build/crone/crone and then build/matron/matron (in another window) once the SC handshake times out, i see:

entering main loop...
softcut: setting enabled: voice 0: 0
softcut: setting voice output level 0: 0
softcut: setting voice input level 0: 0: 0
softcut: setting voice input level 1: 0: 0
softcut: setting enabled: voice 1: 0
softcut: setting voice output level 1: 0
softcut: setting voice input level 0: 1: 0
softcut: setting voice input level 1: 1: 0
softcut: setting enabled: voice 2: 0
softcut: setting voice output level 2: 0
softcut: setting voice input level 0: 2: 0
softcut: setting voice input level 1: 2: 0
softcut: setting enabled: voice 3: 0
softcut: setting voice output level 3: 0
terminate called without an active exception
softcut: setting voice input level 0: 3: 0
softcut: setting voice input level 1: 3: 0
softcut: setting voice input level 1: 3: 0
softcut: setting enabled: voice 4: 0
softcut: setting voice output level 4: 0
softcut: setting voice input level 0: 4: 0
softcut: setting voice input level 1: 4: 0
Aborted

and crone quits. will keep looking.

@catfact
Copy link
Collaborator Author

@catfact catfact commented May 23, 2019

hrm... alright thanks for trying. i will attempt to make some time to revisit...

i kinda suspect there is some other issue with the merge, since it definitely worked at the time (just tested by sending OSC to norns with softcut running.)

@catfact catfact closed this Jun 2, 2019
@catfact catfact deleted the softcut-buffer-workers branch Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants