tape->cut and tape->reverb routing options #827
Merged
Conversation
…>reverb in system/audio
|
@catfact thanks for the pointers on this! thoughts on the default tape->cut setting? |
| @@ -217,6 +227,7 @@ void MixerClient::SmoothLevelList::setSampleRate(float sr) { | |||
| monitor.setSampleRate(sr); | |||
| cut_aux.setSampleRate(sr); | |||
| ext_aux.setSampleRate(sr); | |||
| tape_aux.setSampleRate(sr); | |||
Dewb
May 26, 2019
Author
Contributor
I noticed that none of the ->cut levels have their sample rates set here, is that intentional?
I noticed that none of the ->cut levels have their sample rates set here, is that intentional?
catfact
May 26, 2019
Collaborator
Nope! It’s an oversight
Nope! It’s an oversight
|
super rad! my feeling is that the user script should set up the softcut inputs, which includes tape (and engines). so default should be 0? will be able to look over the code later today |
Dewb
added a commit
to Dewb/norns
that referenced
this pull request
May 31, 2019
tehn
added a commit
that referenced
this pull request
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
So far this PR
rev tape inputmenu param tosystem > audioTape to reverb works great. There's no direct UI exposure of the tape->cut parameter; I was able to test it by running
local audio = require('core\audio') audio.level_tape_cut(18.0)in the maiden console. This is pretty fun, it ends up being a back door way of getting recorded material into mlr.Making the tape->cut default to unity gain would make this step unnecessary, but that seems like a breaking change for people who want to play a backing track unaltered while sampling live input. Not sure if this should be a system level control or up to scripts to manage.
(as discussed here: https://llllllll.co/t/norns-help/14016/1406)