Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tape->cut and tape->reverb routing options #827

Merged
merged 5 commits into from May 26, 2019

Conversation

Projects
None yet
3 participants
@Dewb
Copy link
Contributor

commented May 26, 2019

So far this PR

  • adds tape->cut and tape->aux level params to the crone mixer, initialized to 0 / -inf dB
  • exposes tape->cut and tape->aux as OSC endpoints
  • adds tape->cut and tape->aux methods to the Audio module in matron
  • adds rev tape input menu param to system > audio

Tape to reverb works great. There's no direct UI exposure of the tape->cut parameter; I was able to test it by running local audio = require('core\audio') audio.level_tape_cut(18.0) in the maiden console. This is pretty fun, it ends up being a back door way of getting recorded material into mlr.

Making the tape->cut default to unity gain would make this step unnecessary, but that seems like a breaking change for people who want to play a backing track unaltered while sampling live input. Not sure if this should be a system level control or up to scripts to manage.

(as discussed here: https://llllllll.co/t/norns-help/14016/1406)

@Dewb

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2019

@catfact thanks for the pointers on this! thoughts on the default tape->cut setting?

@@ -217,6 +227,7 @@ void MixerClient::SmoothLevelList::setSampleRate(float sr) {
monitor.setSampleRate(sr);
cut_aux.setSampleRate(sr);
ext_aux.setSampleRate(sr);
tape_aux.setSampleRate(sr);

This comment has been minimized.

Copy link
@Dewb

Dewb May 26, 2019

Author Contributor

I noticed that none of the ->cut levels have their sample rates set here, is that intentional?

This comment has been minimized.

Copy link
@catfact

catfact May 26, 2019

Collaborator

Nope! It’s an oversight

@tehn

This comment has been minimized.

Copy link
Member

commented May 26, 2019

super rad!

my feeling is that the user script should set up the softcut inputs, which includes tape (and engines). so default should be 0?

will be able to look over the code later today

@catfact
Copy link
Collaborator

left a comment

thanks @Dewb looks great!

@tehn

tehn approved these changes May 26, 2019

@tehn tehn merged commit ba25f42 into monome:master May 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Dewb Dewb deleted the Dewb:tape_rev branch May 26, 2019

tehn added a commit that referenced this pull request Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.