add engine loading status flag #846
Merged
Conversation
…engine-lodaed callback
|
Would you prefer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
this makes it so that
engine.load()will skip issuing a load command if there's already one pending. (the function will also returnfalsein this case, andtrueotherwise.)also cleaned up some bad-looking logic in engine-loaded callback, which was conceivably responsible this apparent bug: incomplete command table at script init time, when engine takes long time to load, and no script-level callback is defined.
(https://llllllll.co/t/timber/21407/70)