Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Softcut output filters #854

Closed
wants to merge 2 commits into from
Closed

Conversation

@catfact
Copy link
Collaborator

@catfact catfact commented Jul 8, 2019

added output filter to each softcut voice. the DSP is basically a one-line change, adding commands, OSC and lua is a lot more.

note that this is a breaking change to OSC command list and lua API! the input and output filters need to be differentiated; i replaced filter_ with pre_filter and post_filter

this is completely untested! have not even cleaned up formatting! putting it up just in case anyone has time to get to it before i do (which will be soon but probably not today)

@catfact catfact added the do not merge label Jul 8, 2019
@tehn
Copy link
Member

@tehn tehn commented Jul 8, 2019

i can help on the c/lua glue!

@catfact
Copy link
Collaborator Author

@catfact catfact commented Jul 8, 2019

the new parameters use _norns.cut_param(), so i don't think new c/lua glue is required, and i updated softcut.lua

the main other thing that needs updating is scripts / libraries that call softcut.filter_xyz

@tehn
Copy link
Member

@tehn tehn commented Jul 8, 2019

aha, i see what you mean. this seems done then? just needs doc updates?

breaking change is the addition of pre_ to the existing filters, correct? pretty sure hardly any scripts use them currently, but good to know.

will test. excited to hear this.

side note: i should implement a softcut_defaults OSC message that resets crone instead of sending 400 individual OSC messages...

@catfact
Copy link
Collaborator Author

@catfact catfact commented Jul 8, 2019

breaking change is the addition of pre_ to the existing filters, correct?

yes

this seems done then? just needs doc updates?

it needs testing. i give it a 15% chance of being completely broken right now. will try on hardware ASAP

@catfact catfact mentioned this pull request Jul 8, 2019
@catfact catfact closed this Jul 9, 2019
@catfact catfact deleted the catfact:softcut-output-filters branch Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants