Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clip before tape write #889

Merged
merged 3 commits into from Oct 6, 2019
Merged

Conversation

@catfact
Copy link
Collaborator

@catfact catfact commented Oct 5, 2019

added hardclipper in tape writer class.

out-of-range values were wrapping when encoded to fixed point. (seems like pretty bad behavior from libsndfile, but w/e.)

could probably implement the hardclipper more efficiently, without conditionals, but this will get it done.

@catfact
Copy link
Collaborator Author

@catfact catfact commented Oct 5, 2019

@simonvanderveldt thanks! takeaway is to set SFC_SET_CLIPPING. so, will do that and report back.

@catfact
Copy link
Collaborator Author

@catfact catfact commented Oct 5, 2019

thanks using SF_SET_CLIPPING instead, which is surely more efficient and definitely happens on the right thread.

NB: have only tested on x64 so far

@tehn
Copy link
Member

@tehn tehn commented Oct 6, 2019

fixes #888

(will test on hardware today)

@tehn
tehn approved these changes Oct 6, 2019
@tehn tehn merged commit 4017294 into monome:master Oct 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@catfact catfact deleted the catfact:fix-clip-before-tape-write branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants