Fix system cmd memleak #921
Merged
Conversation
|
last commit is a bit silly, but it reduces mem usage of the subcommand by about 25% compared to |
|
thank you for spotting this. i clearly need to learn more about pthread. |
|
oh, ha. indeed. i'll do another round of cleanup on this. |
|
oy oy oy i apologize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
due to a subtlety of the pthreads API, the worker threads created in
system_cmd.cwere leaking all the memory of the child processes they spawned.(the child process in latest version being a big ol'
findthat ate up a rather shocking 10MB a pop with a goodly number of scripts installed. [um, actually that's not quite right. it's mapped but unwired, or something.])detaching the thread fixes this, it seems.
also uncrustified that file, because someone has their vim set on 2space again. :)