Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert using 'ls' instead of 'find' #930

Merged
merged 1 commit into from Oct 23, 2019

Conversation

@catfact
Copy link
Collaborator

@catfact catfact commented Oct 23, 2019

my bad - tried using ls -R instead of find to search scripts, didn't realize it somehow is not recursing on norns (though seems to work on my archlinux install! most odd.)

reverting to the previous find command for now. this is much slower and more memory-hungry - i suspect because it doesn't skip hidden directories and so is searching through the .git tree in every project.

i tried some variations with find ... -path ... -prune but couldn't get it to work. maybe someone with more advanced bash-fu can suggest an alternative.

emb
@catfact catfact requested a review from tehn Oct 23, 2019
@tehn
tehn approved these changes Oct 23, 2019
@tehn tehn merged commit 110bd9e into monome:master Oct 23, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@catfact catfact deleted the catfact:revert-script-find-command branch Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants