Update to ignore Fates devices for kernel updates #973
Conversation
Does this get the job done?
|
that should work. did you test it? |
|
Went to lunch and just back to test it now. Need to reflash the shield as a comparison. |
copy/paste error. wildcard `*""*`was matching everything
|
i'm going back on this in favor of my initial recommendation after some further discussion. we'd like not to add complexity, create compromises, or add technical debt to future maintainability: basically we don't want to have fates-specific code in the repo. here's how we'd like to see fates continue:
my earlier sentiment about not wanting a bunch of forks was the hope that people would be contributing code that benefits the project broadly instead of focusing on features that wouldn't be compatible with the main project. i think this situation where the update process is incompatible is a perfect use of forking. |
|
Hmmmm. OK. FWIW - I just finished running the second patched version of this and it worked fine on both Fates and the Norns Shield. Back to our previous lines conversation - to not have fates specific content in the main norns repo - I thought it would be good to check for known norns things like the kernel version (uname -r) or something similar and then skip the kernel update if it's NOT norns. That feels it would not create technical debt. |
Does this get the job done?