Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ignore Fates devices for kernel updates #973

Closed
wants to merge 2 commits into from

Conversation

@okyeron
Copy link
Contributor

@okyeron okyeron commented Jan 2, 2020

Does this get the job done?

Does this get the job done?
Copy link
Member

@tehn tehn left a comment

that should work. did you test it?

@okyeron
Copy link
Contributor Author

@okyeron okyeron commented Jan 2, 2020

Went to lunch and just back to test it now. Need to reflash the shield as a comparison.

copy/paste error. wildcard `*""*`was matching everything
@tehn
Copy link
Member

@tehn tehn commented Jan 2, 2020

i'm going back on this in favor of my initial recommendation after some further discussion. we'd like not to add complexity, create compromises, or add technical debt to future maintainability: basically we don't want to have fates-specific code in the repo.

here's how we'd like to see fates continue:

  • fork the norns repo
  • change the SYSTEM > UPDATE procedure so that it does something simple like git pull; ./waf --- or simply remove SYSTEM > UPDATE entirely and have people manually update their norns folder.
  • manually sync your fork to the master repo (you can have some other fates collaborators help you stay on top of this)

my earlier sentiment about not wanting a bunch of forks was the hope that people would be contributing code that benefits the project broadly instead of focusing on features that wouldn't be compatible with the main project. i think this situation where the update process is incompatible is a perfect use of forking.

@tehn tehn closed this Jan 2, 2020
@okyeron
Copy link
Contributor Author

@okyeron okyeron commented Jan 2, 2020

Hmmmm. OK.

FWIW - I just finished running the second patched version of this and it worked fine on both Fates and the Norns Shield.

Back to our previous lines conversation - to not have fates specific content in the main norns repo - I thought it would be good to check for known norns things like the kernel version (uname -r) or something similar and then skip the kernel update if it's NOT norns. That feels it would not create technical debt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants