curses maiden ws compat #980
Merged
Conversation
|
omg you make it look so simple. |
|
super super rad! thanks for taking the time. |
|
...in the end after i understood the basic structure of the code it ended up being simple. the main difference was that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fixes #978
this is a minimal change that allows the original curses based
maidento work along side the web based version. through the magic of nanomsg both the console repl and the web repl work at the same time. input is not echoed to each repl but each repl does see the same output.note: to compile i needed to
sudo apt-get install libncursesw5-devan outstanding issue which this PR doesn't address is the duplicate command names. perhaps it is worth reimplementing this in go and rolling it into the maiden backend command as
maiden repl. one advantage of integrating it in the go based command would be the ability to run it on a different host (along side a non-web based editor).