Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curses maiden ws compat #980

Merged
merged 1 commit into from Jan 20, 2020
Merged

Conversation

@ngwese
Copy link
Member

@ngwese ngwese commented Jan 19, 2020

fixes #978

this is a minimal change that allows the original curses based maiden to work along side the web based version. through the magic of nanomsg both the console repl and the web repl work at the same time. input is not echoed to each repl but each repl does see the same output.

note: to compile i needed to sudo apt-get install libncursesw5-dev

an outstanding issue which this PR doesn't address is the duplicate command names. perhaps it is worth reimplementing this in go and rolling it into the maiden backend command as maiden repl. one advantage of integrating it in the go based command would be the ability to run it on a different host (along side a non-web based editor).

@tehn
tehn approved these changes Jan 20, 2020
Copy link
Member

@tehn tehn left a comment

omg you make it look so simple.

@tehn
Copy link
Member

@tehn tehn commented Jan 20, 2020

super super rad! thanks for taking the time.

@tehn tehn merged commit 0ba4bf1 into monome:master Jan 20, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ngwese
Copy link
Member Author

@ngwese ngwese commented Jan 20, 2020

...in the end after i understood the basic structure of the code it ended up being simple. the main difference was that the ws sockets are bi-directional. it was probably 45 min work in the end.

@ngwese ngwese deleted the ngwese:fix/curses-maiden-ws-compat branch Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants