Skip to content

/ serialosc

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use system libuv instead of submodule? #30

Closed
simonvanderveldt opened this issue Sep 17, 2017 · 5 comments
Closed

Use system libuv instead of submodule? #30

simonvanderveldt opened this issue Sep 17, 2017 · 5 comments

Comments

@simonvanderveldt
Copy link
Member

@simonvanderveldt simonvanderveldt commented Sep 17, 2017

I'd like to propose to use system installed libuv instead of a git submodule. Would it be OK to switch to this?

I have a patch for ./wscript that adds the required check. It's working fine for me (Linux/gentoo, libuv 1.10.2) this way. Can create a PR using this code if you're open to this change.

I guess there's no system installed libuv on macos and windows? So for those the submodule should stay in place?
@wrl
Copy link
Member

@wrl wrl commented Sep 17, 2017

"switch" as in leave no way to build with submodule? no, no chance. submodule is necessary for macOS and windows build, yes.

I'm open to a PR which preferentially uses the system libuv and falls back to the submodule if it's unavailable.
@simonvanderveldt
Copy link
Member Author

@simonvanderveldt simonvanderveldt commented Sep 17, 2017

"switch" as in leave no way to build with submodule? no, no chance. submodule is necessary for macOS and windows build, yes.

OK, I figured as much :)
I'll make sure it only applies to linux

I'm open to a PR which preferentially uses the system libuv and falls back to the submodule if it's unavailable.

Cool, I'll create a PR to do so.
I'd prefer the configure step to fail if there's no system libuv, would that be OK for you?
@wrl
Copy link
Member

@wrl wrl commented Sep 17, 2017

how about it checks for the submodule first and falls back to the system libuv if it's not found? that way it's easier to override the system version if need be (for example, debugging libuv).
@simonvanderveldt
Copy link
Member Author

@simonvanderveldt simonvanderveldt commented Sep 17, 2017 •
edited

Yeah, that makes sense. Allows one to easily override if one wants to and can fail if both are missing. Good idea :)

I'll create a PR that does this.
@simonvanderveldt simonvanderveldt mentioned this issue Oct 28, 2017
Closed
@simonvanderveldt
Copy link
Member Author

@simonvanderveldt simonvanderveldt commented Oct 31, 2017

This was fixed in #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Allow using system installed libuv
2 participants
@wrl @simonvanderveldt