Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos 10.13 /dev string changed #38

Closed
tehn opened this issue Nov 27, 2017 · 6 comments
Closed

macos 10.13 /dev string changed #38

tehn opened this issue Nov 27, 2017 · 6 comments

Comments

@tehn
Copy link
Member

@tehn tehn commented Nov 27, 2017

older series devices with a dash in them ie m64-1000 now show up as m64_1000 in the /dev entries, which makes them undetectable i guess.

@tehn
Copy link
Member Author

@tehn tehn commented Nov 27, 2017

this is actually a libmonome issue, likely solved here:

https://github.com/monome/libmonome/blob/master/src/private/devices.h

@simonvanderveldt
Copy link
Member

@simonvanderveldt simonvanderveldt commented Nov 27, 2017

@tehn Any idea why this is happening? Changes in macOS itself or some supporting library (i.e. could it also happen on another OS)?

@tehn
Copy link
Member Author

@tehn tehn commented Nov 28, 2017

@readywater
Copy link

@readywater readywater commented Nov 30, 2017

@tehn @wrl

Wondering if part of it gets fixed in this statement in libmonome.c, i.e. double checking if it's a dash or an underscore?

static monome_devmap_t *map_serial_to_device(const char *serial) {
	monome_devmap_t *m;
	int serialnum;

	for( m = mapping; m->sermatch; m++ )
		if( sscanf(serial, m->sermatch, &serialnum) )
			return m;

	return NULL;
}

I'd imagine the device.h file might change a bit like this?
{"m128%s%d", "series", {16, 8}, "monome 128", NO_QUIRKS},

Just looking at the source, it seems that's where it's being called in the constructor, around line 81.

And apologies I can't make these changes myself. My C skills (and build environment) are absurd level rusty.

@tehn
Copy link
Member Author

@tehn tehn commented Nov 30, 2017

@tehn
Copy link
Member Author

@tehn tehn commented Dec 6, 2017

in the meantime i've suggested 10.13 users install an old FTDI driver from 2015 which fixes the issue: http://www.ftdichip.com/Drivers/VCP/MacOSX/FTDIUSBSerialDriver_v2_3.dmg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants