Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap write frame index to loop, not buffer #3

Closed
catfact opened this issue Oct 10, 2019 · 1 comment
Closed

wrap write frame index to loop, not buffer #3

catfact opened this issue Oct 10, 2019 · 1 comment

Comments

@catfact
Copy link
Collaborator

@catfact catfact commented Oct 10, 2019

record head position is computed by adding record offset to write head position, then wrapping.

this wraps to buffer size, not to loop size, e.g. here:
https://github.com/monome/norns/blob/master/crone/src/softcut/SubHead.cpp#L130

it doesn't matter until you start changing the offset amount. then you can have material in the loop that was written with the old offset, but which will never be hit with the new offset.

made a branch that had SubHead tracking loop positions in frames and using that for wrapping. but it's not quite enough, because wrap points should be [start, end+fade] when rate > 0, and [start-fade, end] when rate < 0. and rate can change each sample... so this bookkeeping should happen in the parent SoftCutHead, and maybe it's not quite worth it at all.

@catfact catfact transferred this issue from monome/norns Feb 11, 2020
@catfact catfact changed the title softcut: wrap write frame index to loop, not buffer wrap write frame index to loop, not buffer Mar 17, 2020
@catfact
Copy link
Collaborator Author

@catfact catfact commented Mar 17, 2020

closing for now. i don't think variable R/W offset is that useful anyway.

@catfact catfact closed this Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant