New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate commands should not append to the live command history #99

Closed
burnsauce opened this Issue Sep 17, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@burnsauce
Copy link
Contributor

burnsauce commented Sep 17, 2017

No description provided.

@tehn

This comment has been minimized.

Copy link
Member

tehn commented Sep 17, 2017

@burnsauce

This comment has been minimized.

Copy link
Contributor

burnsauce commented Oct 8, 2017

Additionally, the history consumes 1056 bytes. Is this a decent candidate for the heap? It would reduce size on flash, and we already require malloc.

@samdoshi

This comment has been minimized.

Copy link
Collaborator

samdoshi commented Oct 8, 2017

AFAIK uninitialised data doesn’t consume space in the ROM

http://samdoshi.com/post/2016/10/avr32-ram-and-rom-usage/

But I will admit that it’s all a bit confusing. Can you post the output from avr32-objdump and/or avr32-size to show that the ROM sizes does decrease.

@burnsauce

This comment has been minimized.

Copy link
Contributor

burnsauce commented Oct 8, 2017

D'oh. Of course. I suppose it only matters to RAM.

@scanner-darkly

This comment has been minimized.

Copy link
Member

scanner-darkly commented May 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment